use untyped storage for dtensors due to deprecation#39697
Draft
winglian wants to merge 3 commits intohuggingface:mainfrom
Draft
use untyped storage for dtensors due to deprecation#39697winglian wants to merge 3 commits intohuggingface:mainfrom
winglian wants to merge 3 commits intohuggingface:mainfrom
Conversation
Member
|
looks legit but cc @Cyrilvallez for TP! |
Member
|
cc @S1ro1 for a quick check! |
Contributor
|
Will check this, talked about this with Wing and we have been experiencing some issues (maybe because of it), will revisit and improve, the deprecation warning is not pressing matter, as it's still around even in main torch. |
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TypedStorge has been deprecated for a while now pytorch/pytorch@ee28b86 and I'm getting this warning when using TP
similarly, the nbytes size should be based on the underlying storage similar to the accelerate implementation
https://github.com/huggingface/accelerate/blob/2f075c724ccb4e38fade64db3b0627ca167b5fd2/src/accelerate/utils/modeling.py#L201-L202
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.