Skip to content

use untyped storage for dtensors due to deprecation #39697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
winglian wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

use untyped storage for dtensors due to deprecation #39697

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49e6934
use untyped storage for dtensors due to deprecation
winglian Jul 26, 2025
16341a7
use nbytes from storage
winglian Jul 26, 2025
14b9a70
Merge branch 'main' into dtensor-storage
Cyrilvallez Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/transformers/pytorch_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ def id_tensor_storage(tensor: torch.Tensor) -> tuple[torch.device, int, int]:

if isinstance(tensor, DTensor):
local_tensor = tensor.to_local()
return tensor.device, local_tensor.storage().data_ptr(), tensor.nbytes
return tensor.device, local_tensor.untyped_storage().data_ptr(), tensor.untyped_storage().nbytes()

if tensor.device.type == "xla" and is_torch_xla_available():
# NOTE: xla tensors dont have storage
Expand Down