[SqueezeBert] Migrate to standardized output collection decorators#44010
Open
preetam1407 wants to merge 3 commits intohuggingface:mainfrom
Open
[SqueezeBert] Migrate to standardized output collection decorators#44010preetam1407 wants to merge 3 commits intohuggingface:mainfrom
preetam1407 wants to merge 3 commits intohuggingface:mainfrom
Conversation
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
thanks, there is #43590 running I'd like to merge it first
| output_attentions=output_attentions, | ||
| output_hidden_states=output_hidden_states, | ||
| return_dict=return_dict, | ||
| return_dict=True, |
Collaborator
There was a problem hiding this comment.
you should never have to do this, can_return_tuple does it!
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: squeezebert |
ArthurZucker
approved these changes
Apr 13, 2026
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
LGTM, merge_with_config_defaults needs to appear somewhere (was an update) at the top level so at PreTrainedModel levels when neeeded
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#43979.
Refactors SqueezeBert to the standardized output collection interface:
_can_record_outputsinSqueezeBertPreTrainedModel@capture_outputsonSqueezeBertModel.forward@can_return_tupleon task model forwardsoutput_attentions/output_hidden_states/return_dictplumbing and manual collection loopsWho can review?
@ArthurZucker @molbap