[Gemma] Modular-friendly buffers#44635
Open
RyanMullins wants to merge 2 commits intohuggingface:mainfrom
Open
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: cwm, dots1, exaone4, exaone_moe, gemma, gemma2, gemma3, gemma3n, gpt_oss, granitemoehybrid, lfm2, lfm2_moe, minimax, ministral, olmo3, olmo_hybrid |
Cyrilvallez
reviewed
Mar 18, 2026
Member
Cyrilvallez
left a comment
There was a problem hiding this comment.
Arf sorry, maybe I wasn't clear enough offline 🥲 Unfortunately, nn.parameter.Buffer was only added in torch 2.5, and we still support 2.4... So we need to hold off at least a bit for this PR! Let me see internally if we can bump the dependency so we can use this!
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Per a conversion with @Cyrilvallez on Slack on how to make Gemma models more compatible with modular inheritance, this PR:
nn.parameter.Bufferinstead of aself.register_buffer()for static attributes_init_weightsfunctions as appropriate to populate non-persistent buffers correctlyBefore submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ArthurZucker @Cyrilvallez