SwanLab: Add support for id and resume arguments in SwanLabCallback#43779
Open
surya10602 wants to merge 1 commit intohuggingface:mainfrom
Open
SwanLab: Add support for id and resume arguments in SwanLabCallback#43779surya10602 wants to merge 1 commit intohuggingface:mainfrom
surya10602 wants to merge 1 commit intohuggingface:mainfrom
Conversation
MekkCyber
reviewed
Feb 9, 2026
Contributor
MekkCyber
left a comment
There was a problem hiding this comment.
Thank you @surya10602 ! sorry this pr is superseded by #43719
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
SwanLabCallbackto accept**kwargsin its__init__method and passes them toswanlab.init()during setup.Previously, the SwanLab integration did not expose important initialization arguments like
experiment_id,id, orresume. This made it impossible to properly resume training runs (e.g., when usingTrainer.train(resume_from_checkpoint=...)) because SwanLab would create a new experiment instead of continuing the existing one.By allowing
**kwargsto be passed through, users can now maintain experiment continuity across restarts by explicitly passing the run ID.Changes:
SwanLabCallback.__init__to store**kwargs.SwanLabCallback.setupto merge these user-provided arguments intoinit_argsbefore callingswanlab.init.Fixes #43698
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed.