Fix inaccurate eval and train loss computation with variable batch sizes#41904
Open
jameslovespancakes wants to merge 1 commit intohuggingface:mainfrom
Open
Fix inaccurate eval and train loss computation with variable batch sizes#41904jameslovespancakes wants to merge 1 commit intohuggingface:mainfrom
jameslovespancakes wants to merge 1 commit intohuggingface:mainfrom
Conversation
Fixes huggingface#41898 When drop_last=False (default), the last batch may contain fewer samples than per_device_eval_batch_size. Using a fixed batch_size to repeat the scalar loss causes the last batch to be over-represented in the final average loss calculation. Changes: - Trainer: Use observed_batch_size instead of fixed batch_size when repeating eval loss for gather_for_metrics - no_trainer examples: Use actual batch size from input_ids.shape[0] for both eval and train loss computation - Train loss: Weight by actual batch size and divide by total samples instead of number of batches This ensures accurate loss computation regardless of batch size variability while maintaining backward compatibility (identical behavior when all batches are uniform size).
Member
|
The updates to the |
evalstate
added a commit
to evalstate/transformers
that referenced
this pull request
Apr 29, 2026
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41898
When drop_last=False (default), the last batch may contain fewer samples than per_device_eval_batch_size. Using a fixed batch_size to repeat the scalar loss causes the last batch to be over-represented in the final average loss calculation.
Changes:
This ensures accurate loss computation regardless of batch size variability while maintaining backward compatibility (identical behavior when all batches are uniform size).