Fix tokenizer check script: safe dataset access, default checkpoints, and tested in dry-run mode#41698
Open
aijadugar wants to merge 2 commits intohuggingface:mainfrom
Open
Fix tokenizer check script: safe dataset access, default checkpoints, and tested in dry-run mode#41698aijadugar wants to merge 2 commits intohuggingface:mainfrom
aijadugar wants to merge 2 commits intohuggingface:mainfrom
Conversation
… and tested in dry-run mode
aijadugar
commented
Oct 18, 2025
Author
aijadugar
left a comment
There was a problem hiding this comment.
hello team, PR is ready for review...
Member
|
We're not sure we're keeping that script, unfortunately! I don't want to start merging fixes to it right now. |
Author
|
ok @Rocketknight1 , what I do now? |
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what this PR does and summary
This PR improves the
scripts/check_tokenizers.pyscript by:Safe dataset access:
dataset[i]["premise"]anddataset[i]["hypothesis"]safely for the English XNLI dataset.Default checkpoints per tokenizer:
Dry-run tested:
Counters reset per tokenizer:
total,perfect,imperfect,wrongcounters reset for each tokenizer run.Improved error handling:
Example Output