Fix to tuple conversion with config#39257
Open
qubvel wants to merge 1 commit intohuggingface:mainfrom
Open
Conversation
qubvel
commented
Jul 7, 2025
| if return_dict_passed is not None: | ||
| return_dict = return_dict_passed | ||
| output = func(self, *args, **kwargs) | ||
| output = func(self, *args, **kwargs, return_dict=True) |
Contributor
Author
There was a problem hiding this comment.
This way, it's going to work in case **kwargs: [TransformersKwargs] are properly propagated from the top module up to each wrapped module.
Just for the context, previously, we were recursively setting the module attribute _is_top_module to avoid passing **kwargs everywhere.
qubvel
commented
Jul 7, 2025
Comment on lines
-926
to
-946
| def set_attribute_for_modules(module: "torch.nn.Module", key: str, value: Any): | ||
| """ | ||
| Set a value to a module and all submodules. | ||
| """ | ||
| setattr(module, key, value) | ||
| for submodule in module.children(): | ||
| set_attribute_for_modules(submodule, key, value) | ||
|
|
||
|
|
||
| def del_attribute_from_modules(module: "torch.nn.Module", key: str): | ||
| """ | ||
| Delete a value from a module and all submodules. | ||
| """ | ||
| # because we might remove it previously in case it's a shared module, e.g. activation function | ||
| if hasattr(module, key): | ||
| delattr(module, key) | ||
|
|
||
| for submodule in module.children(): | ||
| del_attribute_from_modules(submodule, key) | ||
|
|
||
|
|
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
setting
return_dict=Falsewith config fails for models with sub-models wrapped withcan_return_tupleorcheck_model_inputs