fix: resolve dropout type error in DogeDecoder#40022
Open
wubingheng111 wants to merge 2 commits intohuggingface:mainfrom
Open
fix: resolve dropout type error in DogeDecoder#40022wubingheng111 wants to merge 2 commits intohuggingface:mainfrom
wubingheng111 wants to merge 2 commits intohuggingface:mainfrom
Conversation
Fixed TypeError where dropout() received tuple instead of Tensor in DogeDecoderLayer when using MoE configuration. The MLP forward method returns a tuple (hidden_states, router_logits) for MoE layers, but the subsequent dropout operation expected only a Tensor. - Extract hidden_states from tuple before dropout when using MoE - Ensure consistent tensor handling in both MLP and MoE configurations Fixes issue where model.generate() failed with: TypeError: dropout(): argument 'input' (position 1) must be Tensor, not tuple
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: doge |
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks! Let's push this a little bit: it's weird that no tests caught this! Can you make sure this is tested in tests/models/doge/test_modeling_doge.py ?
evalstate
added a commit
to evalstate/transformers
that referenced
this pull request
Apr 29, 2026
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #40079
Fixed TypeError where dropout() received tuple instead of Tensor in DogeDecoderLayer when using MoE configuration. The MLP forward method returns a tuple (hidden_states, router_logits) for MoE layers, but the subsequent dropout operation expected only a Tensor.
Fixes issue where model.generate() failed with:
TypeError: dropout(): argument 'input' (position 1) must be Tensor, not tuple
@ArthurZucker @gante @LoserCheems