Refactor RemBERT to use output tracing decorators#44085
Open
Zephyr-Blessed wants to merge 1 commit intohuggingface:mainfrom
Open
Refactor RemBERT to use output tracing decorators#44085Zephyr-Blessed wants to merge 1 commit intohuggingface:mainfrom
Zephyr-Blessed wants to merge 1 commit intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gptj |
This was referenced Feb 17, 2026
This was referenced Apr 21, 2026
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors the RemBERT model to use the new output tracing decorators (
@capture_outputsand@can_return_tuple), replacing manual output collection boilerplate.Changes:
@capture_outputsdecorator toRemBertModel.forward()@can_return_tupledecorator to all wrapper model forwards (ForMaskedLM, ForCausalLM, ForSequenceClassification, ForMultipleChoice, ForTokenClassification, ForQuestionAnswering)_can_record_outputsmapping onRemBertPreTrainedModelforhidden_states(RemBertLayer) andattentions(RemBertSelfAttention)output_attentions,output_hidden_states, andreturn_dictparameters from forward signaturesRemBertEncoderloop (removed manual collection of hidden states/attentions)RemBertLayerandRemBertAttentionforward returns to scalar outputs**kwargspassthrough for output tracingFollows the same pattern as the BERT refactor.
Closes #43979