Refactor GPT-J output tracing to use standardized decorators#45365
Closed
burtenshaw wants to merge 1 commit intohuggingface:mainfrom
Closed
Refactor GPT-J output tracing to use standardized decorators#45365burtenshaw wants to merge 1 commit intohuggingface:mainfrom
burtenshaw wants to merge 1 commit intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gptj |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied the overlapping GPT-J refactor from the staged PRs: added
_can_record_outputs, movedGPTJModel.forwardto decorator-based output capture, switched wrapper forwards to@can_return_tuple, and removed manual hidden-state/attention plumbing. Static validation passed (compileall,make style,git diff --check); pytest could not run in this environment becausetorchis unavailable and importingtransformersalso reported missingsafetensorspackage metadata.Target issue: #43979.
Tests:
python -m compileall src/transformers/models/gptj/modeling_gptj.pypython -m pytest tests/models/gptj/test_modeling_gptj.py -qPYTHONPATH=src python -m pytest tests/models/gptj/test_modeling_gptj.py -qmake stylegit diff --checkSource PRs: