make sure position_ids are passed in for causal mask creation for gpt-oss#39997
Open
winglian wants to merge 1 commit intohuggingface:mainfrom
Open
make sure position_ids are passed in for causal mask creation for gpt-oss#39997winglian wants to merge 1 commit intohuggingface:mainfrom
winglian wants to merge 1 commit intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gpt_oss |
ArthurZucker
reviewed
Aug 8, 2025
| "attention_mask": attention_mask, | ||
| "cache_position": cache_position, | ||
| "past_key_values": past_key_values, | ||
| "position_ids": position_ids, |
Collaborator
There was a problem hiding this comment.
ty can you update the modular as well ?!
Member
|
Indeed, needs to be upstreamed in modular as well! |
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Packing won't work with gpt-oss since it doesn't respect the position ids. See #39194
Fixes # (issue)
@ArthurZucker @Cyrilvallez
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.