handle get_input_embeddings() on models like gemma3 gracefully#42542
Open
winglian wants to merge 1 commit intohuggingface:mainfrom
Open
handle get_input_embeddings() on models like gemma3 gracefully#42542winglian wants to merge 1 commit intohuggingface:mainfrom
winglian wants to merge 1 commit intohuggingface:mainfrom
Conversation
zucchini-nlp
reviewed
Dec 2, 2025
Member
zucchini-nlp
left a comment
There was a problem hiding this comment.
Instead of an try/except, we should add the embedding layer's name for siglip model imo. There might be a few more models though that do not have an input embedding layer. Not sure why we didn't catch them with tests
CC @molbap as well who added the feat :)
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#41993 breaks calls to
model.enable_input_require_grads()Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.