[Refactor] Migrate MPT to standardized output tracing decorators#44071
Open
ArivunidhiA wants to merge 1 commit intohuggingface:mainfrom
Open
[Refactor] Migrate MPT to standardized output tracing decorators#44071ArivunidhiA wants to merge 1 commit intohuggingface:mainfrom
ArivunidhiA wants to merge 1 commit intohuggingface:mainfrom
Conversation
Migrate MPT model to use @capture_outputs and @can_return_tuple decorators as part of huggingface#43979. - Add _can_record_outputs to MptPreTrainedModel - Add @merge_with_config_defaults and @capture_outputs to MptModel.forward - Add @can_return_tuple to MptForCausalLM, MptForSequenceClassification, MptForTokenClassification, and MptForQuestionAnswering - Remove manual output_attentions/output_hidden_states/return_dict handling - Simplify MptBlock.forward to return only hidden_states
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: mpt |
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors the MPT model to use the new standardized output collection interface as part of #43979.
Changes:
_can_record_outputstoMptPreTrainedModelmappinghidden_states→MptBlockandattentions→MptAttention@merge_with_config_defaultsand@capture_outputstoMptModel.forward@can_return_tupletoMptForCausalLM,MptForSequenceClassification,MptForTokenClassification, andMptForQuestionAnsweringoutput_attentions/output_hidden_states/return_dictparameter resolution and collection loops fromMptModel.forwardMptBlock.forwardto return onlyhidden_states(attentions captured via hooks)return_dicthandling from all wrapper forwards.last_hidden_state) instead of indexTesting:
All 111 MPT tests pass locally.
Fixes part of #43979