Add Mistral tokenizer missing methods#41855
Open
ChrisHughes wants to merge 1 commit intohuggingface:mainfrom
Open
Add Mistral tokenizer missing methods#41855ChrisHughes wants to merge 1 commit intohuggingface:mainfrom
ChrisHughes wants to merge 1 commit intohuggingface:mainfrom
Conversation
Member
|
cc @itazap |
5 tasks
ArthurZucker
approved these changes
Nov 24, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Ty! Can you rebase ? 🤗
ChrisHughes
force-pushed
the
mistral_tokenizer_add_missing_functions
branch
from
eb5a548 to
0c2ed47
Compare
Author
|
Rebased. Thanks! |
|
Hi, just pinging - what's the status of the PR? Is there any blocker before the merge? |
ChrisHughes
force-pushed
the
mistral_tokenizer_add_missing_functions
branch
from
0c2ed47 to
77ca619
Compare
Author
Should be good to go. Just rebased again. |
ChrisHughes
force-pushed
the
mistral_tokenizer_add_missing_functions
branch
from
77ca619 to
06c12aa
Compare
Make MistralCommonTokenizer compatible with libraries such as outlines.
ChrisHughes
force-pushed
the
mistral_tokenizer_add_missing_functions
branch
from
06c12aa to
cb83ef0
Compare
| def test_convert_tokens_to_string(self): | ||
| tokens = ["Hello", "world", "!"] | ||
| string = self.tokenizer.convert_tokens_to_string(tokens) | ||
| self.assertIsInstance(string, str) |
Collaborator
There was a problem hiding this comment.
can you do a bit more testing! like what do you expect as string here, tokenizer -> convert tokens to string
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Hey @ChrisHughes any updates on this PR? |
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make MistralCommonTokenizer compatible with libraries such as outlines.
Adds a couple of missing methods found in
PreTrainedTokenizer, this allows Mistral models to be used with outlines and thus work with Pydantic models.Builds on this PR #39930.
Fixes issue #39841.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.