[Trainer] Optimize LengthGroupedSampler computation with select_columns and tqdm#45651
Open
AlrIsmail wants to merge 1 commit intohuggingface:mainfrom
Open
[Trainer] Optimize LengthGroupedSampler computation with select_columns and tqdm#45651AlrIsmail wants to merge 1 commit intohuggingface:mainfrom
AlrIsmail wants to merge 1 commit intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses the performance bottleneck reported in #28069, where
LengthGroupedSampler(andDistributedLengthGroupedSampler) can take an extremely long time to compute sequence lengths for large datasets.The root cause was that iterating over a Hugging Face
Datasetwithout column selection forces the backend (Apache Arrow) to deserialize every column for every row, even if only one column (e.g.,input_ids) is needed for length computation.Changes:
dataset.select_columns. If present, we now temporarily select only the required column for the length-calculation loop, drastically reducing I/O and deserialization overhead.logging.tqdmto provide a progress bar during this phase, which is otherwise silent.length_column_namefor maximum efficiency._compute_dataset_lengthsto ensure consistency across both standard and distributed samplers.Benchmark Results (5 Million Rows):
Code Agent Policy
datasetslibrary.I used AI assistance to help diagnose the Apache Arrow bottleneck and refactor the code for better modularity.
Before submitting
Who can review?
@SunMarc