Skip to content

Refactor label name handling for PEFT models in Trainer class#39265

Merged
SunMarc merged 4 commits intomainfrom
refactor-label-names-col-for-peft
Aug 4, 2025
Merged

Refactor label name handling for PEFT models in Trainer class#39265
SunMarc merged 4 commits intomainfrom
refactor-label-names-col-for-peft

Conversation

@qgallouedec
Copy link
Copy Markdown
Member

@qgallouedec qgallouedec commented Jul 8, 2025

What does this PR do?

Fix huggingface/trl#3694

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@SunMarc

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks !

@SunMarc SunMarc enabled auto-merge (squash) July 8, 2025 10:32
@SunMarc SunMarc merged commit 4819adb into main Aug 4, 2025
26 checks passed
@SunMarc SunMarc deleted the refactor-label-names-col-for-peft branch August 4, 2025 06:29
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…gface#39265)

Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…gface#39265)

Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…gface#39265)

Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…gface#39265)

Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…gface#39265)

Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…gface#39265)

Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…gface#39265)

Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No loss logging when using LoraConfig + SFTTrainer

3 participants