Skip to content

Refactor label name handling for PEFT models in Trainer class #39265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SunMarc merged 4 commits into from
Aug 4, 2025
Merged

Refactor label name handling for PEFT models in Trainer class #39265

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b90b518
Refactor label name handling for PEFT models in Trainer class
qgallouedec Jul 8, 2025
5a76728
Merge branch 'main' into refactor-label-names-col-for-peft
SunMarc Jul 8, 2025
a6448c4
Merge branch 'main' into refactor-label-names-col-for-peft
qgallouedec Jul 8, 2025
2c46f9b
Merge branch 'main' into refactor-label-names-col-for-peft
qgallouedec Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/transformers/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,15 +783,17 @@ def __init__(
# returned to 0 every time flos need to be logged
self.current_flos = 0
self.hp_search_backend = None
if _is_peft_model(self.model) and self.args.label_names is None:
logger.warning(
f"No label_names provided for model class `{self.model.__class__.__name__}`."
" Since `PeftModel` hides base models input arguments, if label_names is not given, label_names can't be set automatically within `Trainer`."
" Note that empty label_names list will be used instead."
)
default_label_names = find_labels(self.model.__class__)

model_to_inspect = self.model
if _is_peft_model(self.model):
if hasattr(self.model, "get_base_model"):
model_to_inspect = self.model.get_base_model()
else:
# PeftMixedModel do not provide a `get_base_model` method
model_to_inspect = self.model.base_model.model
default_label_names = find_labels(model_to_inspect.__class__)
self.label_names = default_label_names if self.args.label_names is None else self.args.label_names
self.can_return_loss = can_return_loss(self.model.__class__)
self.can_return_loss = can_return_loss(model_to_inspect.__class__)
self.control = self.callback_handler.on_init_end(self.args, self.state, self.control)

# Internal variables to help with automatic batch size reduction
Expand Down