Fix DynamicCache and simplify Cache classes a bit#39590
Merged
Cyrilvallez merged 8 commits intomainfrom Jul 23, 2025
Merged
Conversation
manueldeprada
approved these changes
Jul 22, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Cyrilvallez
changed the title
Cyrilvallez
changed the title
Member
Author
|
No no it has nothing to do with hardware here - you cannot append if the list does not exist |
Contributor
|
I know! I was mentioning that as a reason for the test to be skipped in the PR tests (since it requires multigpu) |
Cyrilvallez
changed the title
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: bamba, granitemoehybrid, jamba |
ArthurZucker
approved these changes
Jul 23, 2025
This was referenced Jul 29, 2025
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* fix * use kwargs * simplify * Update cache_utils.py * Update cache_utils.py * Update test_cache_utils.py * fix * style
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* fix * use kwargs * simplify * Update cache_utils.py * Update cache_utils.py * Update test_cache_utils.py * fix * style
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* fix * use kwargs * simplify * Update cache_utils.py * Update cache_utils.py * Update test_cache_utils.py * fix * style
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* fix * use kwargs * simplify * Update cache_utils.py * Update cache_utils.py * Update test_cache_utils.py * fix * style
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* fix * use kwargs * simplify * Update cache_utils.py * Update cache_utils.py * Update test_cache_utils.py * fix * style
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* fix * use kwargs * simplify * Update cache_utils.py * Update cache_utils.py * Update test_cache_utils.py * fix * style
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* fix * use kwargs * simplify * Update cache_utils.py * Update cache_utils.py * Update test_cache_utils.py * fix * style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per the title. DynamicCache was broken because
self.layersneeds to exist if we want to append to it ->test_multi_gpu_data_parallel_forwardwas failingcc @manueldeprada for viz