Remove super call from EncoderDecoderCache init#39786
Closed
manueldeprada wants to merge 1 commit intohuggingface:mainfrom
Closed
Remove super call from EncoderDecoderCache init#39786manueldeprada wants to merge 1 commit intohuggingface:mainfrom
manueldeprada wants to merge 1 commit intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
manueldeprada
force-pushed
the
fix-enc-dec-init
branch
from
14c162a to
295e033
Compare
Member
|
Already part of #39797! 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EncoderDecoderCacheis a wrapper around two caches. Thus, it should not call super() to initializeself.layersorself.layer_classes.This can create bugs since other parts of the code might try to access those attributes.
The call was added on #39590