Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SunMarc
commented
Dec 15, 2025
MekkCyber
reviewed
Dec 16, 2025
Contributor
MekkCyber
left a comment
MekkCyber
left a comment
There was a problem hiding this comment.
Amazing ! Thanks for cleaning the dtype mess 🔥
Co-authored-by: Mohamed Mekkouri <93391238+MekkCyber@users.noreply.github.com>
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: diffllama, falcon, falcon_mamba, gpt_neo, gptj, kyutai_speech_to_text, mimi, moshi, nemotron, fbgemm_fp8, finegrained_fp8, gptq, higgs |
MekkCyber
approved these changes
Dec 16, 2025
Contributor
MekkCyber
left a comment
MekkCyber
left a comment
There was a problem hiding this comment.
Incredible, thanks a lot!
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
* fix dtype quantizer * fix * rm print * fix * style * fix * revert * bitnet * fix * gogo * Update src/transformers/modeling_utils.py Co-authored-by: Mohamed Mekkouri <93391238+MekkCyber@users.noreply.github.com> * warn instead * fix * fix --------- Co-authored-by: Mohamed Mekkouri <93391238+MekkCyber@users.noreply.github.com>
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes code related to quantizer since
dtype=autodefault created some minor issues in our CI. We clean a bit of code related to dtype and fixes the tests as some of ours tests depends on the dtype of the model, which before where always ontorch.float32if not specified.