fix failure of pytest tests/models/paddleocr_vl/test_modeling_paddleo…#43001
Closed
sywangyi wants to merge 2 commits intohuggingface:mainfrom
Closed
fix failure of pytest tests/models/paddleocr_vl/test_modeling_paddleo…#43001sywangyi wants to merge 2 commits intohuggingface:mainfrom
sywangyi wants to merge 2 commits intohuggingface:mainfrom
Conversation
tests/models/paddleocr_vl/test_modeling_paddleocr_vl.py::PaddleOCRVLModelTest::test_flash_attn_2_fp32_ln quantization_config is not set in text and visual part. so datatype conversion before flash attn will not be called. Signed-off-by: Wang, Yi <yi.a.wang@intel.com>
79e636e to
a45997a
Compare
Signed-off-by: Wang, Yi <yi.a.wang@intel.com>
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: paddleocr_vl |
ArthurZucker
reviewed
Jan 5, 2026
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
in general we should never have to fix quantization in model specific code! cc @SunMarc
Contributor
|
@SunMarc , could you pls suggest a way for this? Thx very much |
Member
|
Please give the PR above a try ! |
Contributor
Author
yes, this PR fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cr_vl.py::PaddleOCRVLModelTest::test_flash_attn_2_fp32_ln
quantization_config is not set in text and visual part. so datatype conversion before flash attn will not be called.
failure like