Fix: adding pad_token_id in Qwen3VLTextConfig#43398
Merged
zucchini-nlp merged 6 commits intohuggingface:mainfrom Jan 22, 2026
Merged
Fix: adding pad_token_id in Qwen3VLTextConfig#43398zucchini-nlp merged 6 commits intohuggingface:mainfrom
zucchini-nlp merged 6 commits intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: qwen3_vl |
Contributor
Author
|
@zucchini-nlp thanks for the review. I updated the PR based on your feedback. |
zucchini-nlp
approved these changes
Jan 22, 2026
Member
zucchini-nlp
left a comment
zucchini-nlp
left a comment
There was a problem hiding this comment.
Great, thanks for iterating. Merging!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
vaibhav-research
added a commit
to vaibhav-research/transformers
that referenced
this pull request
Jan 22, 2026
* Fix: adding pad_token_id in Qwen3VLTextConfig * Fix: adding pad_token_id in Qwen3VLTextConfig * updated the docstring with pad_token_id * updated the docstring with pad_token_id * added test nested in Qwen3VLModelTest for missing pad_token_id * Updated pad_token_id config and removed the tests
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
* Fix: adding pad_token_id in Qwen3VLTextConfig * Fix: adding pad_token_id in Qwen3VLTextConfig * updated the docstring with pad_token_id * updated the docstring with pad_token_id * added test nested in Qwen3VLModelTest for missing pad_token_id * Updated pad_token_id config and removed the tests
5 tasks
zucchini-nlp
added
the
for patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an initialization error in Qwen3-VL text model construction when loading checkpoints whose nested text_config does not explicitly define pad_token_id.
there are 2 main issues
• Qwen3VLTextModel.init unconditionally accesses config.pad_token_id, but Qwen3VLTextConfig did not define this attribute.
• When loading via from_pretrained, this resulted in an AttributeError during model initialization.
The fix adds pad_token_id to Qwen3VLTextConfig (defaulting to None) and forwards it through PreTrainedConfig, aligning the config schema with what the model expects.
A regression test is added to ensure Qwen3VLTextModel can be instantiated when pad_token_id is not provided.
Fixes #43393 #43334
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@Rocketknight1 @zucchini-nlp
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.