Fix failing tests due to no attribute pad_token_id#43453
Fix failing tests due to no attribute pad_token_id#43453zucchini-nlp merged 17 commits intohuggingface:mainfrom
pad_token_id#43453Conversation
Sai-Suraj-27
force-pushed
the
fix_missing_attr
branch
from
d524951 to
b9f8ed1
Compare
zucchini-nlp
left a comment
zucchini-nlp
left a comment
There was a problem hiding this comment.
Thanks a lot for fixing these, let's fix all pad_token_id's in this PR!
Overall lgtm, we just need to update modular files and run make fix-repo
| Dictionary containing the configuration parameters for the RoPE embeddings. The dictionary should contain | ||
| a value for `rope_theta` and optionally parameters used for scaling in case you want to use RoPE | ||
| with longer `max_position_embeddings`. | ||
| pad_token_id (`int | None`, *optional*): <fill_docstring> |
There was a problem hiding this comment.
could you fix the docstring and add pad_token_id in modular file?
There was a problem hiding this comment.
Sorry, for the dealy. Fixed the Doc-string. Can you take a look now? The failing quality check in CI is asking to add a duplicate line: self.pad_token_id = pad_token_id. So, I am not sure if it's correct.
| self.seconds_per_chunk = seconds_per_chunk # zf | ||
| self.audio_start_token_id = audio_start_token_id # zf | ||
| self.audio_end_token_id = audio_end_token_id # zf | ||
| self.pad_token_id = pad_token_id |
There was a problem hiding this comment.
has to go in modular file first
|
[For maintainers] Suggested jobs to run (before merge) run-slow: glm4v, glm_image, glm_ocr, phi, qwen2_5_omni, qwen3_vl_moe |
zucchini-nlp
left a comment
zucchini-nlp
left a comment
There was a problem hiding this comment.
Let's merge! There might be more models left, but we'll have a PR with @Rocketknight1 on that
Thanks for your efforts @Sai-Suraj-27 !
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hmellor
added
the
for patch
4 participants
What does this PR do?
Fixes these failing PhiIntegrationTest, Glm46VIntegrationTest, Qwen3VLMoeIntegrationTest & Qwen2_5OmniModelIntegrationTest tests.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@zucchini-nlp (Continuation to #41541 #43398) @Rocketknight1