Skip to content

Create README.md#8025

Merged
JetRunner merged 2 commits intohuggingface:masterfrom
longenbach:patch-1
Oct 25, 2020
Merged

Create README.md#8025
JetRunner merged 2 commits intohuggingface:masterfrom
longenbach:patch-1

Conversation

@longenbach
Copy link
Copy Markdown
Contributor

@longenbach longenbach commented Oct 24, 2020

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to the it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.

@julien-c julien-c added the model card Related to pretrained model cards label Oct 24, 2020
@JetRunner JetRunner merged commit 5148f43 into huggingface:master Oct 25, 2020
@julien-c
Copy link
Copy Markdown
Member

we should probably validate model ids (to something like [\w\d-_]{3,}) @Pierrci, mind creating an issue for this?

julien-c added a commit that referenced this pull request Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model card Related to pretrained model cards

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants