Skip to content

[LED Test] fix common inputs pt for flaky pt-tf led test#9459

Merged
patrickvonplaten merged 2 commits intohuggingface:masterfrom
patrickvonplaten:fix_led_flaky
Jan 7, 2021
Merged

[LED Test] fix common inputs pt for flaky pt-tf led test#9459
patrickvonplaten merged 2 commits intohuggingface:masterfrom
patrickvonplaten:fix_led_flaky

Conversation

@patrickvonplaten
Copy link
Copy Markdown
Contributor

@patrickvonplaten patrickvonplaten commented Jan 7, 2021

What does this PR do?

Fixes flaky led test: tests/test_modeling_tf_led.py::TFLEDModelTest::test_pt_tf_model_equivalence. It's the classic bug for Longformer, I forgot to set the global attention mask correctly for the common inputs for PT

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.

@patrickvonplaten patrickvonplaten changed the title [LED Test] fix common inputs pt flaky led [LED Test] fix common inputs pt for flaky pt-tf led test Jan 7, 2021
@patrickvonplaten
Copy link
Copy Markdown
Contributor Author

@LysandreJik @sgugger - should fix flaky TFLED test.

@sgugger
Copy link
Copy Markdown
Collaborator

sgugger commented Jan 7, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants