[TF Led] Fix flaky TF Led test#9513
Merged
patrickvonplaten merged 1 commit intohuggingface:masterfrom Jan 11, 2021
Merged
Conversation
Contributor
Author
Collaborator
|
Thanks for fixing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The reason why the TF LED test is flaky was not fully fixed in: #9459
and is actually the following:
Currently the
decoder_attention_maskcan have a0at its first input:Since the decoder uses a causal mask, this however leads to problems as a softmax over only very large negative numbers in computed. Now since TF and PT use slightly different large numbers, we can see significant differences between the models. The solution is to make sure that the
decoder_attention_maskused for thetf_pt_equivalencetest cannot be zero at the first position (I've done the same changes for all TFBart models in: #9497 and also made sure in #9497 that the TF templates are correctly updated )