Fix CI with dev dependencies for Llava models#5499
Merged
albertvillanova merged 5 commits intohuggingface:mainfrom Apr 20, 2026
Merged
Fix CI with dev dependencies for Llava models#5499albertvillanova merged 5 commits intohuggingface:mainfrom
albertvillanova merged 5 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
As it seems the underlying issue is a bug upstream (pending to be fixed), I'm closing this PR in favor of: |
Member
Author
|
After further investigation, the
I'm reopening this PR. |
qgallouedec
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CI with dev dependencies for Llava models, after the merge in
transformersof this PR:Fix #5497.
This PR updates the test logic in both
test_sft_trainer.pyandtest_dpo_trainer.pyto support changes in the model parameter naming introduced intransformersdev (version 5.6.0 and above). The changes ensure that the tests correctly handle both the old and new parameter names, improving compatibility across different versions of thetransformerslibrary.Changes
Test compatibility improvements:
test_train_vlmintests/test_sft_trainer.pyto handle both pre-5.6.0 and 5.6.0+ versions of thetransformerslibrary for Llava and LlavaNext models.test_train_vlmintests/test_dpo_trainer.pyfor Llava and LlavaNext models to ensure compatibility with the new naming conventions intransformers5.6.0 and above.Note
Low Risk
Low risk since changes are confined to test expectations and CI behavior, but they may re-enable previously flaky Llava/LlavaNext runs depending on upstream
transformersdev changes.Overview
Removes the
xfailgating fortiny-Llava*VLM cases in bothtest_sft_trainer.pyandtest_dpo_trainer.py, so these models run normally even ontransformersdev builds.Updates the VLM parameter-change assertion skip list to recognize the new Llava/LlavaNext vision-tower parameter names in
transformers>=5.6.0(while keeping the old names for earlier versions), preventing false CI failures due to upstream renames (see #5497).Reviewed by Cursor Bugbot for commit 55f4200. Bugbot is set up for automated code reviews on this repo. Configure here.