Skip to content

Hotfix CI: Mark tests as xfail with transformers dev for Llava models#5504

Merged
albertvillanova merged 1 commit intohuggingface:mainfrom
albertvillanova:hotfix-5497
Apr 10, 2026
Merged

Hotfix CI: Mark tests as xfail with transformers dev for Llava models#5504
albertvillanova merged 1 commit intohuggingface:mainfrom
albertvillanova:hotfix-5497

Conversation

@albertvillanova
Copy link
Copy Markdown
Member

@albertvillanova albertvillanova commented Apr 10, 2026

Hotfix CI: Mark tests as xfail with transformers dev for Llava models.

Hotfix for:

Pending of a fix upstream.


Note

Low Risk
Low risk: only adjusts pytest expectations for CI by marking known-failing Llava/LlavaNext cases as xfail on transformers dev releases, with no production code changes.

Overview
Marks the Llava and LlavaNext vision-language model cases in test_train_vlm for both DPOTrainer and SFTTrainer as conditional xfail when running against transformers dev releases.

This prevents CI failures from a known upstream transformers 5.6.0.dev0 issue (see #5497) while keeping the tests strict for other versions.

Reviewed by Cursor Bugbot for commit 5cc6495. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5cc6495. Configure here.

Comment thread tests/test_dpo_trainer.py
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Member

@qgallouedec qgallouedec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@albertvillanova albertvillanova merged commit 462e028 into huggingface:main Apr 10, 2026
11 of 13 checks passed
albertvillanova added a commit to albertvillanova/trl that referenced this pull request Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants