Update tests with zero3 for RLOO and GRPO once fixed in transformers 5.5.4#5541
Merged
albertvillanova merged 2 commits intohuggingface:mainfrom Apr 14, 2026
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
kashif
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update tests with zero3 for RLOO and GRPO once fixed in transformers 5.5.4.
This PR updates the test conditions for ZeRO-3 integration with the
transformerslibrary to reflect a recent upstream fix. The tests now only expect failures for a specific range oftransformersversions where the issue is known to occur, improving the accuracy of test expectations.Fix #4899, after the upstream issue in
transformers:has been fixed by:
Follow-up to:
TestGRPOTrainer.test_training_vlm_and_ligerand update version checks #4898Changes
Test condition updates:
test_rewardandtest_rloointests/distributed/test_distributed.py, thepytest.mark.xfailcondition for the "zero3" parameter is updated to only expect failures whentransformersversion is greater than or equal to 5.0.0 and less than 5.5.4, reflecting that the issue is fixed intransformers#45414. The reason message is also updated for clarity.Note
Low Risk
Low risk: only adjusts pytest
xfailversion gating and messages in distributed tests, with no production code changes.Overview
Updates distributed tests so the
zero3parameter is only markedxfailfortransformersversions>= 5.0.0and< 5.5.4, reflecting that the upstream ZeRO-3 issue is fixed intransformers5.5.4.Also updates the associated
xfailreason strings (and keepsstrict=True) intest_rlooandtest_grpoto document the fixed upstream PR/reference.Reviewed by Cursor Bugbot for commit fef7620. Bugbot is set up for automated code reviews on this repo. Configure here.