Skip to content

E2E: make sure that contract account's state doesn't vanish after emptying its wallet#1398

Merged
quasiyoke merged 5 commits intomasterfrom
e2e-contract-factories-nonce
Feb 10, 2025
Merged

E2E: make sure that contract account's state doesn't vanish after emptying its wallet#1398
quasiyoke merged 5 commits intomasterfrom
e2e-contract-factories-nonce

Conversation

@quasiyoke
Copy link
Contributor

@quasiyoke quasiyoke commented Jan 13, 2025

No description provided.

quasiyoke added a commit that referenced this pull request Jan 13, 2025
@quasiyoke
E2E-test: withdrawAll from the contracts' factory between two CREATEs
2aa985f 
(#1398)
quasiyoke added a commit that referenced this pull request Jan 13, 2025
@quasiyoke
Use payable constructor instead of deposit (#1398)
5407697
@quasiyoke quasiyoke force-pushed the e2e-contract-factories-nonce branch from ca6cb4a to 5407697 Compare January 13, 2025 15:28
MOZGIII
MOZGIII reviewed Jan 13, 2025
View reviewed changes
MOZGIII
MOZGIII reviewed Jan 13, 2025
View reviewed changes
MOZGIII
MOZGIII reviewed Jan 13, 2025
View reviewed changes
MOZGIII
MOZGIII reviewed Jan 13, 2025
View reviewed changes
MOZGIII
MOZGIII reviewed Jan 13, 2025
View reviewed changes
MOZGIII
MOZGIII reviewed Jan 13, 2025
View reviewed changes
MOZGIII
MOZGIII reviewed Jan 13, 2025
View reviewed changes
MOZGIII
MOZGIII approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@MOZGIII MOZGIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has a lot of nits, and probably things that are worth discussion - but it looks like it should capture the bug precisely!

I suggest adding an assertion or a debug print of the nonce of the contract in between the calls to show it nore obviosuly where the fail is.

Good stuff!

quasiyoke added a commit that referenced this pull request Jan 14, 2025
@quasiyoke
E2E-test: withdrawAll from the contracts' factory between two CREATEs
cd208f7 
(#1398)
quasiyoke added a commit that referenced this pull request Jan 14, 2025
@quasiyoke
Use payable constructor instead of deposit (#1398)
4a77332
@quasiyoke quasiyoke force-pushed the e2e-contract-factories-nonce branch from 5407697 to 4a77332 Compare January 14, 2025 11:17
quasiyoke added a commit that referenced this pull request Jan 16, 2025
@quasiyoke
E2E-test: withdrawAll from the contracts' factory between two CREATEs
1d6726f 
(#1398)
quasiyoke added a commit that referenced this pull request Jan 16, 2025
@quasiyoke
Use payable constructor instead of deposit (#1398)
bf9176c
quasiyoke added a commit that referenced this pull request Jan 16, 2025
@quasiyoke
Don't check isOwner invariant in the smart contract directly (#1398)
7c79815
quasiyoke added a commit that referenced this pull request Jan 16, 2025
@quasiyoke
Hardcode gas values (#1398)
1e7254d
quasiyoke added a commit that referenced this pull request Jan 16, 2025
@quasiyoke
Await calls in parallel (#1398)
d5810d2
@quasiyoke quasiyoke force-pushed the e2e-contract-factories-nonce branch from 4a77332 to d5810d2 Compare January 16, 2025 12:26
quasiyoke added a commit that referenced this pull request Jan 16, 2025
@quasiyoke
Hardcode gas values (#1398)
4749b50
quasiyoke added a commit that referenced this pull request Jan 16, 2025
@quasiyoke
Await calls in parallel (#1398)
5960ae9
@quasiyoke quasiyoke force-pushed the e2e-contract-factories-nonce branch from d5810d2 to 5960ae9 Compare January 16, 2025 12:29
MOZGIII
MOZGIII reviewed Jan 16, 2025
View reviewed changes
quasiyoke added a commit that referenced this pull request Jan 16, 2025
@quasiyoke
E2E-test: withdrawAll from the contracts' factory between two CREATEs
a7a0b00 
(#1398)
quasiyoke added a commit that referenced this pull request Jan 16, 2025
@quasiyoke
Use payable constructor instead of deposit (#1398)
83b05c4
quasiyoke added a commit that referenced this pull request Jan 16, 2025
@quasiyoke
Don't check isOwner invariant in the smart contract directly (#1398)
605024c
quasiyoke added a commit that referenced this pull request Jan 16, 2025
@quasiyoke
Hardcode gas values (#1398)
7cb9cf1
quasiyoke added a commit that referenced this pull request Jan 16, 2025
@quasiyoke
Await calls in parallel (#1398)
fabf3f3
@quasiyoke quasiyoke force-pushed the e2e-contract-factories-nonce branch from 5960ae9 to fabf3f3 Compare January 16, 2025 12:41
quasiyoke added a commit that referenced this pull request Jan 16, 2025
@quasiyoke
Hardcode gas values, remove excess calls (#1398)
52f4b51
quasiyoke added a commit that referenced this pull request Jan 16, 2025
@quasiyoke
Check contract account's nonce directly (#1398)
0d69f6c
@quasiyoke quasiyoke force-pushed the e2e-contract-factories-nonce branch from fabf3f3 to 0d69f6c Compare January 16, 2025 16:14
quasiyoke added a commit that referenced this pull request Jan 16, 2025
@quasiyoke
Hardcode gas values, remove excess calls (#1398)
8eaf785
quasiyoke added a commit that referenced this pull request Jan 16, 2025
@quasiyoke
Check contract account's nonce directly (#1398)
ed4b94c
@quasiyoke quasiyoke force-pushed the e2e-contract-factories-nonce branch from 0d69f6c to ed4b94c Compare January 16, 2025 16:27
@quasiyoke quasiyoke changed the title E2E contract factories' nonce E2E: make sure that contract account's state doesn't vanish after emptying its wallet Jan 16, 2025
@quasiyoke quasiyoke force-pushed the e2e-contract-factories-nonce branch from ed4b94c to 05d27ee Compare January 16, 2025 16:33
dmitrylavrenov
dmitrylavrenov reviewed Jan 16, 2025
View reviewed changes
dmitrylavrenov
dmitrylavrenov reviewed Jan 16, 2025
View reviewed changes
dmitrylavrenov
dmitrylavrenov approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@dmitrylavrenov dmitrylavrenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmitrylavrenov dmitrylavrenov mentioned this pull request Jan 16, 2025
Closed
@dmitrylavrenov dmitrylavrenov marked this pull request as ready for review January 16, 2025 16:49
@quasiyoke quasiyoke force-pushed the e2e-contract-factories-nonce branch from 05d27ee to d7645ca Compare January 16, 2025 17:17
MOZGIII
MOZGIII reviewed Jan 17, 2025
View reviewed changes
@quasiyoke quasiyoke force-pushed the e2e-contract-factories-nonce branch from d7645ca to bed6532 Compare January 17, 2025 11:34
@quasiyoke quasiyoke mentioned this pull request Jan 17, 2025
Merged
quasiyoke added a commit that referenced this pull request Jan 30, 2025
@quasiyoke
Apply nonce manager and parallel awaiting (#1398)
6aeced9
@quasiyoke quasiyoke force-pushed the e2e-contract-factories-nonce branch from 4300d60 to 069513c Compare February 10, 2025 10:29
@quasiyoke quasiyoke added this pull request to the merge queue Feb 10, 2025
Merged via the queue into master with commit 213e899 Feb 10, 2025
21 checks passed
@quasiyoke quasiyoke deleted the e2e-contract-factories-nonce branch February 10, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MOZGIII MOZGIII MOZGIII approved these changes

@dmitrylavrenov dmitrylavrenov dmitrylavrenov approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@quasiyoke @MOZGIII @dmitrylavrenov