Properly manage contract accounts creation and removal logic#140
Merged
dmitrylavrenov merged 40 commits intoh-polkadot-v0.9.42from Feb 7, 2025
Merged
Conversation
dmitrylavrenov
force-pushed
the
h-polkadot-v0.9.42-evm-system-has-code
branch
8 times, most recently
from
9dbc917 to
c8483fb
Compare
MOZGIII
reviewed
Jan 16, 2025
quasiyoke
approved these changes
Jan 17, 2025
dmitrylavrenov
force-pushed
the
h-polkadot-v0.9.42-evm-system-has-code
branch
from
4a607de to
528f984
Compare
MOZGIII
reviewed
Jan 20, 2025
MOZGIII
approved these changes
Jan 20, 2025
MOZGIII
left a comment
MOZGIII
left a comment
There was a problem hiding this comment.
Now this makes a lot of sense to me, great job
MOZGIII
reviewed
Jan 20, 2025
MOZGIII
reviewed
Jan 20, 2025
dmitrylavrenov
force-pushed
the
h-polkadot-v0.9.42-evm-system-has-code
branch
2 times, most recently
from
eb53a6a to
713788f
Compare
quasiyoke
approved these changes
Jan 21, 2025
dmitrylavrenov
force-pushed
the
h-polkadot-v0.9.42-evm-system-has-code
branch
from
94e580d to
7ffe45b
Compare
MOZGIII
reviewed
Jan 29, 2025
MOZGIII
reviewed
Jan 29, 2025
dmitrylavrenov
force-pushed
the
h-polkadot-v0.9.42-evm-system-has-code
branch
from
eaf31de to
1f079ca
Compare
dmitrylavrenov
force-pushed
the
h-polkadot-v0.9.42-evm-system-has-code
branch
from
e55ff60 to
af00754
Compare
dmitrylavrenov
force-pushed
the
h-polkadot-v0.9.42-evm-system-has-code
branch
from
9ebdc83 to
1acbad9
Compare
MOZGIII
reviewed
Feb 5, 2025
MOZGIII
approved these changes
Feb 5, 2025
MOZGIII
left a comment
MOZGIII
left a comment
There was a problem hiding this comment.
I like the overall cleanup of the API surface and a more concious approach to implementing the necrssary traits.
I think this is a job well done.
I have a question regarding the account creation - maybe we can address it quickly, but if not let's leave it as us.
This seems to have landed on a good spot and I think it's time to move forward.
MOZGIII
reviewed
Feb 5, 2025
quasiyoke
approved these changes
Feb 5, 2025
This was referenced Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for humanode-network/humanode#1402