Skip to content

Bump the rust toolchain to nightly-2025-02-07#1428

Closed
dmitrylavrenov wants to merge 2 commits intomasterfrom
bump-rust-nightly-2025-02-07
Closed

Bump the rust toolchain to nightly-2025-02-07#1428
dmitrylavrenov wants to merge 2 commits intomasterfrom
bump-rust-nightly-2025-02-07

Conversation

@dmitrylavrenov
Copy link
Contributor

No description provided.

Copy link
Contributor

@MOZGIII MOZGIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but the try runtime crashes

@dmitrylavrenov
Copy link
Contributor Author

dmitrylavrenov commented Feb 7, 2025

The changes look good, but the try runtime crashes

Checked. Unfortunately, substrate should be updated to next versions. Tried to find rust toolchain version by binary search that covers both cases but looks like the current version is almost the latest that is satisfied for current used substrate fork related to polkadot-v0.9.42.

So, to be #1426 compiled at humanode repo we should either backport substrate some future changes or avoid using get_or_insert_default at pallet-evm-system introduced here - humanode-network/frontier#140

@MOZGIII Should I just avoid using get_or_insert_default at pallet-evm-system?

@dmitrylavrenov
Copy link
Contributor Author

dmitrylavrenov commented Feb 7, 2025

Btw, already prepared the version pallet-evm-system that is satisfied current rust toolchain at humanode repo - humanode-network/frontier#154

@MOZGIII
Copy link
Contributor

MOZGIII commented Feb 8, 2025

Should I just avoid using get_or_insert_default at pallet-evm-system?

I think so, yes.

Btw, already prepared the version pallet-evm-system that is satisfied current rust toolchain at humanode repo - humanode-network/frontier#154

The get_or_insert_default is a new one, but there's been get_or_insert_with for ages, so we can switch to that.

@dmitrylavrenov
Copy link
Contributor Author

Not need for now

@dmitrylavrenov dmitrylavrenov deleted the bump-rust-nightly-2025-02-07 branch February 8, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants