Clear all storage items associated with removed Offences pallet at runtime level#1434
Merged
dmitrylavrenov merged 2 commits intomasterfrom Feb 11, 2025
Merged
Conversation
MOZGIII
reviewed
Feb 11, 2025
Contributor
MOZGIII
left a comment
There was a problem hiding this comment.
The code looks good, but we should really test it hard on the mainnet fork before merging.
Contributor
|
As in, real fork, cause try runtime can be a bit relaxed to the block limits and etc |
Contributor
Author
Got it, will take snapshot and do usual testing! |
…ms associated with removed Offences pallet
98fa621 to
c97771c
Compare
Contributor
Author
Prepared a patched fork based on |
quasiyoke
approved these changes
Feb 11, 2025
MOZGIII
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A part of #1383
Done using RemovePallet
try-runtimerun over mainnet: