Skip to content

Clear all storage items associated with removed Offences pallet at runtime level#1434

Merged
dmitrylavrenov merged 2 commits intomasterfrom
remove-offences-pallet-storage
Feb 11, 2025
Merged

Clear all storage items associated with removed Offences pallet at runtime level#1434
dmitrylavrenov merged 2 commits intomasterfrom
remove-offences-pallet-storage

Conversation

@dmitrylavrenov
Copy link
Contributor

@dmitrylavrenov dmitrylavrenov commented Feb 10, 2025

A part of #1383

Done using RemovePallet

try-runtime run over mainnet:

2025-02-10 17:57:06.354  INFO main frame_support::migrations: Found Offences keys pre-removal 👀    
2025-02-10 17:57:06.481  INFO main frame_support::migrations: Removed 80814 Offences keys 🧹    
2025-02-10 17:57:06.819  INFO main frame_support::migrations: No Offences keys found post-removal 🎉 

@dmitrylavrenov dmitrylavrenov marked this pull request as ready for review February 10, 2025 18:05
Copy link
Contributor

@MOZGIII MOZGIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but we should really test it hard on the mainnet fork before merging.

@MOZGIII
Copy link
Contributor

MOZGIII commented Feb 11, 2025

As in, real fork, cause try runtime can be a bit relaxed to the block limits and etc

@dmitrylavrenov
Copy link
Contributor Author

The code looks good, but we should really test it hard on the mainnet fork before merging.

Got it, will take snapshot and do usual testing!

@dmitrylavrenov dmitrylavrenov force-pushed the remove-offences-pallet-storage branch from 98fa621 to c97771c Compare February 11, 2025 11:59
@dmitrylavrenov
Copy link
Contributor Author

The code looks good, but we should really test it hard on the mainnet fork before merging.

Prepared a patched fork based on 11509363 block. Successfully executed sudo runtime upgrade transaction.

2025-02-11 15:11:54 🙌 Starting consensus session on top of parent 0x5434b9097c7b3728286f3be9417afd3bfd52ed21ec21119f8bd8b66fa0a393f3    
2025-02-11 15:11:54 🎁 Prepared block for proposing at 13 (4793 ms) [hash: 0x4a7d6449452b2384e06842b39ead780d6d872a8ab0a0d3e37d9eb732b212e51f; parent_hash: 0x5434…93f3; extrinsics (1): [0xa954…a574]]    
2025-02-11 15:11:55 💤 Idle (0 peers), best: #12 (0x5434…93f3), finalized #0 (0x2bb9…85ba), ⬇ 0 ⬆ 0    
2025-02-11 15:11:55 Removed 80814 Offences keys 🧹    
2025-02-11 15:11:55 ⚠️ HumanodeSession declares internal migrations (which *might* execute). On-chain `StorageVersion(1)` vs current storage version `StorageVersion(1)`    
2025-02-11 15:11:55 Running migration to v1 from StorageVersion(1)    
2025-02-11 15:11:55 Already at version 1, nothing to do    
2025-02-11 15:11:55 ⚠️ Ethereum declares internal migrations (which *might* execute). On-chain `StorageVersion(0)` vs current storage version `StorageVersion(0)`    
2025-02-11 15:11:55 ⚠️ BalancedCurrencySwapBridgesInitializer declares internal migrations (which *might* execute). On-chain `StorageVersion(1)` vs current storage version `StorageVersion(1)`    
2025-02-11 15:11:55 ⚠️ EvmBalancesErc20Support declares internal migrations (which *might* execute). On-chain `StorageVersion(1)` vs current storage version `StorageVersion(1)`    
2025-02-11 15:11:55 ⚠️ DummyPrecompilesCode declares internal migrations (which *might* execute). On-chain `StorageVersion(1)` vs current storage version `StorageVersion(1)`    
2025-02-11 15:12:00 💤 Idle (0 peers), best: #12 (0x5434…93f3), finalized #0 (0x2bb9…85ba), ⬇ 0 ⬆ 0    
2025-02-11 15:12:00 🎁 Prepared block for proposing at 13 (4614 ms) [hash: 0x21a7fcc8cb22eff975263352eba5d3fdfffb9447e6a1b3d6324b7673acfa599d; parent_hash: 0x5434…93f3; extrinsics (1): [0xbc17…545e]]    
2025-02-11 15:12:00 🔖 Pre-sealed block for proposal at 13. Hash now 0x2a3dce29402ee08cb87fa0372360b74d82befb5163812fbd8e807b2240baff6a, previously 0x21a7fcc8cb22eff975263352eba5d3fdfffb9447e6a1b3d6324b7673acfa599d.    
2025-02-11 15:12:00 ✨ Imported #13 (0x2a3d…ff6a)    
2025-02-11 15:12:00 🙌 Starting consensus session on top of parent 0x2a3dce29402ee08cb87fa0372360b74d82befb5163812fbd8e807b2240baff6a    
2025-02-11 15:12:00 🎁 Prepared block for proposing at 14 (4 ms) [hash: 0x09f15f9a9138b7e1d6fcb9361bccbfdc3101d585103bfb78f16f272ba8ab9499; parent_hash: 0x2a3d…ff6a; extrinsics (1): [0x2790…b4f5]]    
2025-02-11 15:12:00 🔖 Pre-sealed block for proposal at 14. Hash now 0x46639208c168b6a3586dd9bb6fc042d9714f91d2132c8de8ee99322c726e0295, previously 0x09f15f9a9138b7e1d6fcb9361bccbfdc3101d585103bfb78f16f272ba8ab9499.    
2025-02-11 15:12:00 ✨ Imported #14 (0x4663…0295)    
2025-02-11 15:12:05 💤 Idle (0 peers), best: #14 (0x4663…0295), finalized #0 (0x2bb9…85ba), ⬇ 0 ⬆ 0    
2025-02-11 15:12:06 🙌 Starting consensus session on top of parent 0x46639208c168b6a3586dd9bb6fc042d9714f91d2132c8de8ee99322c726e0295    
2025-02-11 15:12:06 🎁 Prepared block for proposing at 15 (3 ms) [hash: 0x04cd7b47f6c42deefea133a241de56e2785dbf1220150f8d65269ea600a64497; parent_hash: 0x4663…0295; extrinsics (1): [0x542f…4ba6]]    
2025-02-11 15:12:06 🔖 Pre-sealed block for proposal at 15. Hash now 0x9f7fb2911c538a5f4e62b1b3fa4877aacb8bc05a46c421becfd48c226b6dfabd, previously 0x04cd7b47f6c42deefea133a241de56e2785dbf1220150f8d65269ea600a64497.    
2025-02-11 15:12:06 ✨ Imported #15 (0x9f7f…fabd)    
2025-02-11 15:12:10 💤 Idle (0 peers), best: #15 (0x9f7f…fabd), finalized #0 (0x2bb9…85ba), ⬇ 0 ⬆ 0    
2025-02-11 15:12:12 🙌 Starting consensus session on top of parent 0x9f7fb2911c538a5f4e62b1b3fa4877aacb8bc05a46c421becfd48c226b6dfabd    
2025-02-11 15:12:12 🎁 Prepared block for proposing at 16 (4 ms) [hash: 0x1a42bd27a8069bc8e89dceef55e287841aa063c021fa22c863edc2d6b5df222d; parent_hash: 0x9f7f…fabd; extrinsics (1): [0xa3ce…fe4d]]    
2025-02-11 15:12:12 🔖 Pre-sealed block for proposal at 16. Hash now 0x8d42cab60def7ebb8c90a93794dd072b24afb072ff1d64b0f4b5bd71a9bd9fdf, previously 0x1a42bd27a8069bc8e89dceef55e287841aa063c021fa22c863edc2d6b5df222d.    
2025-02-11 15:12:12 ✨ Imported #16 (0x8d42…9fdf) 

@dmitrylavrenov dmitrylavrenov added this pull request to the merge queue Feb 11, 2025
Merged via the queue into master with commit 34a6ab0 Feb 11, 2025
21 checks passed
@dmitrylavrenov dmitrylavrenov deleted the remove-offences-pallet-storage branch February 11, 2025 18:49
dmitrylavrenov added a commit that referenced this pull request Feb 18, 2025
github-merge-queue bot pushed a commit that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants