Implement own RemovePallet logic taking into account limit value#1441
Closed
dmitrylavrenov wants to merge 9 commits intomasterfrom
Closed
Implement own RemovePallet logic taking into account limit value#1441dmitrylavrenov wants to merge 9 commits intomasterfrom
RemovePallet logic taking into account limit value#1441dmitrylavrenov wants to merge 9 commits intomasterfrom
Conversation
Contributor
Author
|
It's better to wait substrate deps update containing - https://github.com/paritytech/substrate/issues/13690 instead of doing it by ourself for now |
Contributor
|
Please create an issue for this |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @quasiyoke by noting that consumed weight is much higher than a total weight at #1433 (comment). The root cause comes from #1434.
Proposing to add
RemovePalletbased on [frame_support::migrations::RemovePallet], but doesn't focus just on removing all storage items per one runtime upgrade in one block. Additionally, it allows to use capabilities ofclear_prefixwith limit that can be used to partially delete a prefix storage in case it is too large to delete in one block.try-runtimeover current master with offences removaltry-runtimeover proposed code with offences removal