Skip to content

Automatic currency-swap proxy primitives#685

Merged
MOZGIII merged 2 commits intomasterfrom
autoswap
Jul 2, 2023
Merged

Automatic currency-swap proxy primitives#685
MOZGIII merged 2 commits intomasterfrom
autoswap

Conversation

@MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Jun 30, 2023

No description provided.

@MOZGIII MOZGIII requested a review from dmitrylavrenov June 30, 2023 22:33
@MOZGIII
Copy link
Contributor Author

MOZGIII commented Jun 30, 2023

@dmitrylavrenov, so check this out. This is what will allow us to pass the fees and dust removals to the native treasury and fees pots.
One issue I have discovered while working on this is our CurrencySwap::swap call does not allow access to the original NegativeImbalance in case of failure. We should probably rework the CurrencySwap trait API and implementation such that the API ensures we don't ever lose the NegativeImbalance - as it should never just disappear in the swap.
Please let me know what you think.
If you agree - let's get to work! We can merge all we have currently to master and then apply a corrective fix over all of the implementations that involve CurrencySwap.

@MOZGIII MOZGIII marked this pull request as ready for review June 30, 2023 22:39
This was referenced Jun 30, 2023
Merged
Merged
@MOZGIII
Copy link
Contributor Author

MOZGIII commented Jul 1, 2023

Change of plans, we merge the fix early and apply updates to the respective PRs.

@MOZGIII MOZGIII force-pushed the autoswap branch 3 times, most recently from 85f5fb8 to b71103f Compare July 1, 2023 16:53
@MOZGIII
Copy link
Contributor Author

MOZGIII commented Jul 1, 2023

@dmitrylavrenov this has been rebased and finalized for the merge, please take another look for a final review

@MOZGIII MOZGIII mentioned this pull request Jul 1, 2023
Closed
32 tasks
@MOZGIII MOZGIII added this pull request to the merge queue Jul 2, 2023
Merged via the queue into master with commit 6072d77 Jul 2, 2023
@MOZGIII MOZGIII deleted the autoswap branch July 2, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmitrylavrenov dmitrylavrenov dmitrylavrenov approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MOZGIII @dmitrylavrenov