Have StatusCode::as_str return static reference#380
Open
upsuper wants to merge 1 commit intohyperium:masterfrom
Open
Have StatusCode::as_str return static reference#380upsuper wants to merge 1 commit intohyperium:masterfrom
upsuper wants to merge 1 commit intohyperium:masterfrom
Conversation
upsuper
changed the title
Contributor
Author
Contributor
|
CI was restored in a different way (#387), so you might try to merge with master to get this PR passing. |
upsuper
force-pushed
the
as-str-static
branch
from
1e18306 to
a071b4e
Compare
Contributor
Author
|
Thanks! |
Contributor
Author
|
So... the CI is still broken. I'd suggest you mark nightly with allow_failures, especially given that you have |
upsuper
force-pushed
the
as-str-static
branch
from
a071b4e to
ec84b4f
Compare
Contributor
Author
|
@dekellum could you have another look? it seems that I can't re-request review, and I have no idea why. |
Contributor
|
Your rebased change continues to look good to me! But I have no commit rights here, nor do I endorse, much less understand, its "governance". All resent commits are by @seanmonstar and @carllerche was previously active. You might try requesting a review from them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.