CI related fixes#381
Conversation
Denying _all_ warnings causes local tree development trouble. The intent can be better captured by RUSTFLAGS=-Dwarnings in CI.
This crate uses static strings for error messages throughout and in
many cases Display or outer error are implemented by calling
`description()`. We silence these kinds of warnings for now:
warning: use of deprecated item 'std::error::Error::description':
use the Display impl or to_string()
--> src/header/name.rs:2006:14
|
2006 | self.description().fmt(f)
| ^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
by adding `#[allow(deprecated)]` where necessary. Once the ecosystem
has had more time to transition away from `StdError::description`,
this can be revisited, likely by pulling out description
implementations here completely, possibly moving these static messages
to const values.
|
We should probably just remove the |
|
I've restored deny warnings in CI (ccd3701), using what I believe is a better way (also seen in use in tokio, etc.) Or do you not like that approach? Removing the Thus I've taken the more conservative approach of silencing the warnings for now. I suggest revisiting a few rust releases after 1.41 is stable. |
|
Always a pleasure. |
|
Ouch, I'm sorry I forgot about this :( |
|
Your memory aside, I suspect you have also decided not to worry about the possibility of end-users seeing (e.g. on stderr in console) runtime error messages of the form "description() is deprecated; use Display". Yes of course that implies they are using the deprecated |
2 participants
I'll start by demonstrating that CI is broken (on latest master, due to a new deprecation) and go on to fix those things with edits here.