Skip to content

In Snap Sync store Bodies and Receipts ASAP #9588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
pinges wants to merge 262 commits into
base: main
Choose a base branch
from
Draft

In Snap Sync store Bodies and Receipts ASAP #9588

pinges wants to merge 262 commits into from

Conversation

@pinges
Copy link
Contributor

@pinges pinges commented Dec 19, 2025

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

usmansaleem and others added 30 commits December 15, 2025 10:25
@usmansaleem @macfarla @pinges
chore: Update log4j to 2.25.2 (hyperledger#9312)
86f1b11 
Signed-off-by: Usman Saleem <usman@usmans.info>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@bshastry @claude
@usmansaleem @siladu @pinges
Add test summary reporting to block-test command (hyperledger#9246)
6b61de1 
* Add test summary reporting to block-test command

The block-test command now tracks and displays a summary of test
execution results, including total tests, passed/failed counts, and
a list of failed tests with their failure reasons. This improves
usability when running large test suites by providing a clear
overview of test outcomes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Bhargava Shastry <bhargava.shastry@ethereum.org>

* Refactor block-test summary output for better maintainability

Address code review feedback by:
- Extract separator string into SEPARATOR constant to reduce duplication
- Reuse failureReason variable in output statements instead of duplicating
  formatting logic

This improves code maintainability by consolidating the failure message
formatting in a single location.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Bhargava Shastry <bhargava.shastry@ethereum.org>

* Address review feedback: simplify TestResults implementation

- Remove unused testName parameter from recordPass() method
- Remove totalTests field and calculate it dynamically in printSummary()
  from passed + failed counts
- Simplify SEPARATOR constant by removing embedded newline and use
  explicit out.println() for consistent formatting
- Add hasTests() helper method to check if any tests were executed

This reduces redundant state tracking and improves code clarity.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Bhargava Shastry <bhargava.shastry@ethereum.org>

---------

Signed-off-by: Bhargava Shastry <bhargava.shastry@ethereum.org>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Usman Saleem <usman@usmans.info>
Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@mirgee @pinges
Only add CALL recipient to BAL if read (hyperledger#9314)
0043360 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@Matilda-Clerke @pinges
Implement era1 file export (hyperledger#9081)
f130d24 
* Implement era1 file export

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Clean up OutputStreamFactory to pass inspections

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* fix javadoc

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* fix javadoc

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* fix more compile checks

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* fix more compile checks

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* fix more compile checks

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Output era1 files to supplied directory

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Implement accumulator and block index

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Fix compile errors

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Fix javadoc

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Couple of fixes, add logging

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Implement our own merkleizer, try many things

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Fix accumulator calculations

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Fix block number to file number calculation

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Correctly use accumulator hash in era1 filename

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Update manual test to use nimbus.team source for expected era1 file

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Add javadoc to new Era1* files

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Fix BlocksSubCommandTest

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Add MerkleizerTest

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Refactor to produce Era1FileWriter

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Add unit test for Era1FileWriter, fix discovered bug in Era1FileWriter

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Refactor to produce Era1Accumulator and add unit test

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Refactor to produce Era1BlockIndexConverter and add unit test

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Unit test Era1BlockExporter

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Fix javadoc issues

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Rename difficultysForFile to difficultiesForFile

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Move network selection outside of loop

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Make blocks export option non-hidden, add changelog entry

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Use network option in era1 block exporter

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Change Era1BlockExporter.export arguments to start/end block, and handle file number conversion internally

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Add additional Merkleizer tests and guard against empty leaves

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Fix BlocksSubCommandTest

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Move new rlp encoder classes into encoding package, add encodeWrapped for BlockBodyEncoder, add TransactionReceiptEncodingConfiguration parameter to TransactionReceiptEncoder.encode

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

---------

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@Gabriel-Trintinalia @pinges
Revert "Fix: colored output is lost with 25.7.0 (hyperledger#9250)" (h…
1cdb79d 
…yperledger#9320)

This reverts commit 42306f9.

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@macfarla @pinges
changelog (hyperledger#9322)
f31edf7 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@daniellehrner @pinges
Request block builder to finalize when we get a getPayload request (h…
72f1912 
…yperledger#9194)

Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@ahamlat @pinges
remove parentBeaconBlockRoot from getPayload result (hyperledger#9316)
0a08952 
* remove parentBeaconBlockRoot from getPayload result to match the specs

Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@macfarla @pinges
tweaks to release checklist and container verify script (hyperledger#…
1dac634 
…9318)

* add burn-in tasks

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@lu-pinto @pinges
Enable/disable trace fields for RPCs that dump traces to files (hyper…
caf34d7 
…ledger#9183)

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

Allows for enabling and disabling stack, storage, returnData, etc.. for these 2 specific RPC endpoints: debug_traceStandardBlockToFile and debug_traceStandardBadBlockToFile. It does not change any previous defaults for memory which is shown by default.

Example of usage:

curl --location --globoff 'http://localhost:8545' --data '{
    "jsonrpc": "2.0",
    "method": "debug_standardTraceBlockToFile",
    "params": [
        "0x2476b23a03dd87f272724a12213dc4a1ca8f13a1aa9d128a690e1b7d7d312e5e",
        {
            "txHash": "0xdfd5028da0f2f306ae71dc558c26bb1935b13ec3a0e909223eaa77bf761189a8",
            "disableStack": true,
            "disableMemory": false,
            "disableStorage": false
        }
    ],
    "id": 1
}'

curl --location --globoff 'http://localhost:8545/' --data '{
    "jsonrpc": "2.0",
    "method": "debug_standardTraceBadBlockToFile",
    "params": [
        "0x2476b23a03dd87f272724a12213dc4a1ca8f13a1aa9d128a690e1b7d7d312e5e",
        {
            "txHash": "0xdfd5028da0f2f306ae71dc558c26bb1935b13ec3a0e909223eaa77bf761189a8",
            "disableStack": true,
            "disableMemory": false,
            "disableStorage": false
        }
    ],
    "id": 1
}'

Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@fab-10 @pinges
Cancelling a block creation, only stops the selection, to allow the b…
6213be6 
…lock to be completed (hyperledger#9332)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@lu-pinto @pinges
Provide SECP256R1 default to precompile (hyperledger#9307)
71e6b06 
Also remove sigleton pattern from ReferenceTestProtocolSchedules.

Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@macfarla @pinges
Update Netty to 4.2.7.Final (hyperledger#9330)
df52377 
* update netty

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@mirgee @pinges
Do not load recipient account when calculating CALL gas cost if trans…
1c1e6bc 
…fer value is zero (hyperledger#9315)

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@Matilda-Clerke @pinges
Remove GetBlockFromPeerTask and RetryingGetBlockFromPeerTask, replaci…
46fdda9 
…ng with peer task system usage (hyperledger#9178)

* Remove GetBlockFromPeerTask and RetryingGetBlockFromPeersTask, replacing with peer task system usage

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Fix BackwardSyncContextTest

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Use preferred peer first for block retrieval in BlockPropagationManager

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Add new GetHeadersFromPeerTask constructor which doesn't take a block number and use it in SyncStepStep

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Refactor PeerTaskExecutor usage in BlockPropagationManager for better readability

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Fix a != that should have been ==

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Re-add AbstractBlockPropagationManagerTest.shouldRequestBlockFromOtherPeersIfFirstPeerFails and modify to use mock PeerTaskExecutor

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Re-add BackwardSyncContextTest.whenBlockNotFoundInPeers_shouldRemoveBlockFromQueueAndProgressInNextSession

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Fix BlocksSubCommandTest again, but differently

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

* Remove commented code

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

---------

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@Gabriel-Trintinalia @pinges
chore: eip-7935 bump mainnet gas limit to 60M (hyperledger#9339)
a2d1103 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
check whether we are syncing earlier in fcu
cce24e5 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@fab-10 @pinges
Interrupt running selection task when block creation is cancelled (hy…
0aa284e 
…perledger#9337)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@fab-10 @pinges
Introduce a more versatile txpool lifecycle logging (hyperledger#9333)
1a0a781 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@macfarla @pinges
CLI Tests - assert no errors before other assertions (hyperledger#9340)
946e94f 
* assert no errors before asserting method calls

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@jflo @macfarla @pinges
exclude icebox'd issues from being marked stale (hyperledger#9328)
6886fe1 
* exclude icebox'd issues from being marked stale

Signed-off-by: jflo <justin+github@florentine.us>

* Update .github/workflows/stale-issues.yml

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>

---------

Signed-off-by: jflo <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@macfarla @pinges
add instructions for DCO into DCO.md (hyperledger#9317)
ab368eb 
* add instructions for DCO into DCO.md

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
add logging
5b68d85 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
more logging
de03e78 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
make it really simple and do a lot in parallel
d2b833e 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
download all headers and remember last successfull block
2dc2454 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
fix off by one
51835ad 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@jframe @pinges
Support blob fee market when zeroBaseFee enabled for forks with blobs (…
82da875 
…hyperledger#9344)

Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@mirgee @matkt @pinges
Calculate world state root hash from BAL in parallel to block process…
464d2f6 
…ing (hyperledger#9327)

Co-authored-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@garyschulte @pinges
make BesuVersionUtils graal-safe (hyperledger#9342)
924dec2 
* make BesuVersionUtils graal-safe

Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
pinges and others added 30 commits December 15, 2025 10:28
@pinges
more unit tests
d182c7a 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
fix file generation
0cfe5ac 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@Gabriel-Trintinalia @pinges
refactor: move target gas limit to network definition (hyperledger#9502)
06999b3 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
cleanup
0aac223 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
some logging and comment improvements
9b7e7c0 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
Merge branch 'main' of github.com:hyperledger/besu into HeadersBackward
43c5eac 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
fix some problems
187e7cd 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
fix bft acceptance test
25130b9 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
Merge branch 'main' of github.com:hyperledger/besu into HeadersBackward
d4498cd
@pinges
add consensus as well
67bc075 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
fix unit test
8a845f5 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
remove some redundant tests and fix others
4127ed6 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
remove and fix some more unit tests
f1612ba 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
Merge branch 'main' of github.com:hyperledger/besu into HeadersBackward
acc2f80
@pinges
more test clean-up
0defe82 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
Merge branch 'main' of github.com:hyperledger/besu into HeadersBackward
8d66657
@pinges
experiment with storing earlier
4e3e092 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
experiment with storing earlier
5a2e992 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
use old peer task system for receipts
2d329b5 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
remove unsused
05458fe 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
just 3x
30700c2 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
double the size of the write buffer
53c234f 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
Merge branch 'main' of github.com:hyperledger/besu into BW1Step
19f1d40
@pinges
back to 4x
44577cb 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
add logging for EncOfRlpException and disconnections
2c3e3a7 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
Merge branch 'main' of github.com:hyperledger/besu into BW1Step
9be809e
@pinges
print the data
13f44f9 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
fix memory leak
ace2bda 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
increase rocks db buffer size
ffc2703 
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
@pinges
Merge branch 'main' of github.com:hyperledger/besu into BW1Step
b6a71b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.