adding getBooleanAttribute method to data-model(TraceAttributeUtils)#42
Merged
kotharironak merged 4 commits intohypertrace:mainfrom Feb 17, 2023
Merged
adding getBooleanAttribute method to data-model(TraceAttributeUtils)#42kotharironak merged 4 commits intohypertrace:mainfrom
kotharironak merged 4 commits intohypertrace:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
============================================
+ Coverage 67.23% 68.31% +1.07%
- Complexity 125 129 +4
============================================
Files 13 13
Lines 586 587 +1
Branches 96 96
============================================
+ Hits 394 401 +7
+ Misses 166 159 -7
- Partials 26 27 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
singhalprerana
previously approved these changes
Feb 16, 2023
| .thenReturn(Attributes.newBuilder().setAttributeMap(attributeMap).build()); | ||
| assertFalse(TraceAttributeUtils.getBooleanAttribute(mockTrace, "someattribute")); | ||
|
|
||
| attributeMap.put("someattribute", AttributeValue.newBuilder().setValue("true").build()); |
Contributor
There was a problem hiding this comment.
Can you add test case for negetive case and see if its not throwing any exception?
attributeMap.put("someattribute", AttributeValue.newBuilder().setValue("xyz").build());
attributeMap.put("someattribute", AttributeValue.newBuilder().setValue("").build());
kotharironak
approved these changes
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.