Skip to content

adding getBooleanAttribute method to data-model(TraceAttributeUtils) #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kotharironak merged 4 commits into from
Feb 17, 2023
Merged

adding getBooleanAttribute method to data-model(TraceAttributeUtils) #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0027ee9
adding getBooleanAttribute method to data-model(TraceAttributeUtils)
Vaibhav090420 Feb 16, 2023
009e847
added unit tests
Vaibhav090420 Feb 16, 2023
6c027d5
unit test for xyz & empty
Vaibhav090420 Feb 17, 2023
4faff26
spotless check
Vaibhav090420 Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions data-model/src/main/java/org/hypertrace/core/datamodel/shared/TraceAttributeUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ public static boolean containsAttribute(StructuredTrace trace, String attribute)
&& trace.getAttributes().getAttributeMap().containsKey(attribute);
}

public static boolean getBooleanAttribute(StructuredTrace trace, String attribute) {
return Boolean.parseBoolean(getStringAttribute(trace, attribute));
}

public static String getStringAttribute(StructuredTrace trace, String attribute) {
if (trace.getAttributes() == null) {
return null;
Expand Down
36 changes: 36 additions & 0 deletions data-model/src/test/java/org/hypertrace/core/datamodel/shared/TraceAttributeUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
package org.hypertrace.core.datamodel.shared;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

Expand Down Expand Up @@ -35,4 +37,38 @@ public void getListAttributeTest() {
List.of("somevalue1", "somevalue2"),
TraceAttributeUtils.getListAttribute(mockTrace, "someattribute"));
}

@Test
public void getStringAttributeTest() {
StructuredTrace mockTrace = mock(StructuredTrace.class);
assertNull(TraceAttributeUtils.getStringAttribute(mockTrace, "someattribute"));

Map<String, AttributeValue> attributeMap = new HashMap<>();
when(mockTrace.getAttributes())
.thenReturn(Attributes.newBuilder().setAttributeMap(attributeMap).build());
assertNull(TraceAttributeUtils.getStringAttribute(mockTrace, "someattribute"));

attributeMap.put("someattribute", AttributeValue.newBuilder().setValue("somevalue").build());
assertEquals("somevalue", TraceAttributeUtils.getStringAttribute(mockTrace, "someattribute"));
}

@Test
public void getBooleanAttributeTest() {
StructuredTrace mockTrace = mock(StructuredTrace.class);
assertFalse(TraceAttributeUtils.getBooleanAttribute(mockTrace, "someattribute"));

Map<String, AttributeValue> attributeMap = new HashMap<>();
when(mockTrace.getAttributes())
.thenReturn(Attributes.newBuilder().setAttributeMap(attributeMap).build());
assertFalse(TraceAttributeUtils.getBooleanAttribute(mockTrace, "someattribute"));

attributeMap.put("someattribute", AttributeValue.newBuilder().setValue("true").build());
Copy link
Copy Markdown
Contributor

@kotharironak kotharironak Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test case for negetive case and see if its not throwing any exception?

attributeMap.put("someattribute", AttributeValue.newBuilder().setValue("xyz").build());

attributeMap.put("someattribute", AttributeValue.newBuilder().setValue("").build());

assertTrue(TraceAttributeUtils.getBooleanAttribute(mockTrace, "someattribute"));

attributeMap.put("someOtherAttribute", AttributeValue.newBuilder().setValue("xyz").build());
assertFalse(TraceAttributeUtils.getBooleanAttribute(mockTrace, "someOtherAttribute"));

attributeMap.put("otherAttribute", AttributeValue.newBuilder().setValue("").build());
assertFalse(TraceAttributeUtils.getBooleanAttribute(mockTrace, "otherAttribute"));
}
}