Merged
Conversation
aaron-steinfeld
commented
Oct 22, 2021
| uses: snyk/actions/setup@0.3.0 | ||
| - name: Snyk test | ||
| run: snyk test --all-sub-projects --org=hypertrace --severity-threshold=low --policy-path=.snyk --configuration-matching='^runtimeClasspath$' | ||
| run: snyk test --all-sub-projects --org=hypertrace --severity-threshold=low --policy-path=.snyk --configuration-matching='^runtimeClasspath$' --remote-repo-url='${{ github.server_url }}/${{ github.repository }}.git' |
Contributor
Author
There was a problem hiding this comment.
Hopefully this works. I verified that it does when hardcoded, but this should make it easier to copy into more repos. This change won't take effect until post-merge though.
Contributor
Author
There was a problem hiding this comment.
Confirmed working (but it failed because new vulnerabilities since it hasn't been running 😦 )
Codecov Report
@@ Coverage Diff @@
## main #145 +/- ##
=========================================
Coverage 62.26% 62.26%
Complexity 332 332
=========================================
Files 43 43
Lines 3254 3254
Branches 380 380
=========================================
Hits 2026 2026
Misses 1045 1045
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
JBAhire
approved these changes
Oct 22, 2021
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 26, 2021
suddendust
pushed a commit
to suddendust/entity-service
that referenced
this pull request
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two separate fixes here.
Codecov: bash uploader is being deprecated and is currently in the brownout phase. We need to upgrade to the v2 gh action in all repos.
More info: https://about.codecov.io/blog/codecov-uploader-deprecation-plan/
Snyk: Snyk changed their server implementation, and the default remote uri detection no longer works. After weeks with snyk support, they made some changes and now this works, we need to add this param for all invocations.