Skip to content

ci: fix codecov and snyk #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaron-steinfeld merged 1 commit into from
Oct 22, 2021
Merged

ci: fix codecov and snyk #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,6 @@ jobs:
- name: Setup snyk
uses: snyk/actions/setup@0.3.0
- name: Snyk test
run: snyk test --all-sub-projects --org=hypertrace --severity-threshold=low --policy-path=.snyk --configuration-matching='^runtimeClasspath$'
run: snyk test --all-sub-projects --org=hypertrace --severity-threshold=low --policy-path=.snyk --configuration-matching='^runtimeClasspath$' --remote-repo-url='${{ github.server_url }}/${{ github.repository }}.git'
Copy link
Copy Markdown
Contributor Author

@aaron-steinfeld aaron-steinfeld Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this works. I verified that it does when hardcoded, but this should make it easier to copy into more repos. This change won't take effect until post-merge though.

Copy link
Copy Markdown
Contributor Author

@aaron-steinfeld aaron-steinfeld Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working (but it failed because new vulnerabilities since it hasn't been running 😦 )

env:
SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
6 changes: 2 additions & 4 deletions .github/workflows/pr-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,9 @@ jobs:
args: jacocoTestReport

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
uses: codecov/codecov-action@v2
with:
name: unit test reports
fail_ci_if_error: true
flags: unit

- name: Integration test
Expand All @@ -46,10 +45,9 @@ jobs:
args: jacocoIntegrationTestReport

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
uses: codecov/codecov-action@v2
with:
name: integration test reports
fail_ci_if_error: true
flags: integration

- name: copy test reports
Expand Down