feat: use a modified batch span processor that creates metrics#201
Merged
tim-mwangi merged 14 commits intomainfrom Jan 31, 2023
Merged
feat: use a modified batch span processor that creates metrics#201tim-mwangi merged 14 commits intomainfrom
tim-mwangi merged 14 commits intomainfrom
Conversation
Set up otel go metrics reporting and add a RequestCount metric for the http handler instrumentation.
This is to track spans received and dropped by the processor.
ryanericson
reviewed
Jan 28, 2023
ryanericson
approved these changes
Jan 29, 2023
Codecov Report
@@ Coverage Diff @@
## main #201 +/- ##
==========================================
- Coverage 64.99% 59.45% -5.54%
==========================================
Files 49 53 +4
Lines 1774 2200 +426
==========================================
+ Hits 1153 1308 +155
- Misses 570 832 +262
- Partials 51 60 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is to track spans received and dropped by the processor. Currently the processor silently drops spans when the queue is full which is quite difficult to debug. There's a debug log but then this means the user modifying their code to enable it and the logs being quite noisy. Using metrics is much better.
Testing
Tested locally.
Checklist: