Skip to content

feat: use a modified batch span processor that creates metrics #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tim-mwangi merged 14 commits into from
Jan 31, 2023
Merged

feat: use a modified batch span processor that creates metrics #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
073ad15
feat: otel go metrics setup
tim-mwangi Jan 24, 2023
ca7b03c
cleanup metrics init
tim-mwangi Jan 24, 2023
500d088
fix lint check fail in open census libs
tim-mwangi Jan 24, 2023
9c8b2ca
update golangci lint gha to v0.3.4
tim-mwangi Jan 25, 2023
48c419b
fix failing unit test
tim-mwangi Jan 25, 2023
2c36f66
add service instance id to metrics resource
tim-mwangi Jan 25, 2023
9bf078d
add metrics enabled config
tim-mwangi Jan 26, 2023
1cebe35
use main branch for agent-config
tim-mwangi Jan 26, 2023
8fa8a85
feat: use a modified batch span processor that creates metrics
tim-mwangi Jan 27, 2023
023d45e
bsp sampled metrics
tim-mwangi Jan 30, 2023
813e408
Merge remote-tracking branch 'origin/main' into metrics-round-2
tim-mwangi Jan 30, 2023
e5fedb7
fix lint issue
tim-mwangi Jan 30, 2023
7fca494
fix failing unit test
tim-mwangi Jan 30, 2023
fe1ac96
define logger for modified bsp
tim-mwangi Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions instrumentation/opentelemetry/batchspanprocessor/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Modified Batch Span Processor

Since the original BatchSpanProcessor does not send metrics for spans received and spans dropped, the modified BatchSpanProcessor creates and populates those metrics so the user can track whether there are spans being dropped.
Comment thread
ryanericson marked this conversation as resolved.

We have kept track of the original files modified so it's easier to figure out the changes we added. When upgrading, copy the newer files into their go.original counterparts and then do a diff with the modified.go files to figure out what changes to make in order to upgrade the modified files.

The paths of the files modified:
- [sdk/trace/batch_span_processor.go](https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/trace/batch_span_processor.go)
- [sdk/internal/env/env.go](https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/internal/env/env.go)

Since we cannot use [the internal logger]((https://github.com/open-telemetry/opentelemetry-go/blob/main/internal/global/internal_logging.go)), we have adapted it at [logger.go](instrumentation/opentelemetry/batchspanprocessor/logger.go).
Loading