adding generic attributes interface #217
Merged
tim-mwangi merged 5 commits intohypertrace:mainfrom Nov 7, 2023
Merged
Conversation
Contributor
Author
|
We would need to use fmt.Sprintf before passing the values to the filter, shall we just store the attributes as strings itself in that case? @ryanericson @tim-mwangi |
Codecov Report
@@ Coverage Diff @@
## main #217 +/- ##
==========================================
+ Coverage 58.81% 58.94% +0.12%
==========================================
Files 55 55
Lines 2229 2236 +7
==========================================
+ Hits 1311 1318 +7
Misses 859 859
Partials 59 59
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
tim-mwangi
reviewed
Nov 6, 2023
tim-mwangi
reviewed
Nov 7, 2023
tim-mwangi
reviewed
Nov 7, 2023
tim-mwangi
reviewed
Nov 7, 2023
tim-mwangi
approved these changes
Nov 7, 2023
Collaborator
tim-mwangi
left a comment
There was a problem hiding this comment.
lgtm. @ryanericson please take a look as well since you were the original author for this :)
ryanericson
reviewed
Nov 7, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding a generic GetAll method for attributes so that all the attributes can be queried at once
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.