adding iterator interface and removing GetAll() method from attribute list#220
Merged
tim-mwangi merged 4 commits intohypertrace:mainfrom Nov 13, 2023
Merged
adding iterator interface and removing GetAll() method from attribute list#220tim-mwangi merged 4 commits intohypertrace:mainfrom
tim-mwangi merged 4 commits intohypertrace:mainfrom
Conversation
varkey98
commented
Nov 11, 2023
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
==========================================
+ Coverage 58.94% 59.56% +0.61%
==========================================
Files 55 55
Lines 2236 2248 +12
==========================================
+ Hits 1318 1339 +21
+ Misses 859 850 -9
Partials 59 59
... and 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
added 2 commits
November 13, 2023 01:49
tim-mwangi
reviewed
Nov 13, 2023
tim-mwangi
approved these changes
Nov 13, 2023
ryanericson
approved these changes
Nov 13, 2023
Contributor
Author
|
@ryanericson @tim-mwangi Please merge this pr, I cant merge since I dont have write access |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an iterator interface on AttributeList so that the iterator can be queried without creating an additional slice.
Continuation of this pr: #217
ref: https://github.com/hypertrace/goagent/pull/217/files#r1385540220
Checklist: