Skip to content

fix: the integration test with latest pinot image for group.id change #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaron-steinfeld merged 4 commits into from
Jun 28, 2022
Merged

fix: the integration test with latest pinot image for group.id change #146

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1faab51
fix: the integration test with latest pinot image for group.id change
kotharironak Jun 28, 2022
fc8d0c8
making it 5 mins for worst case
kotharironak Jun 28, 2022
1dd589f
updated comments
kotharironak Jun 28, 2022
55856df
reverted the test image
kotharironak Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions .../integrationTest/java/org/hypertrace/core/query/service/htqueries/HTPinotQueriesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,21 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.util.UUID;
import java.util.concurrent.ExecutionException;
import java.util.function.Function;
import java.util.stream.Collectors;
import java.util.stream.Stream;
import org.apache.avro.file.DataFileReader;
import org.apache.avro.specific.SpecificDatumReader;
import org.apache.kafka.clients.admin.AdminClient;
import org.apache.kafka.clients.admin.ConsumerGroupListing;
import org.apache.kafka.clients.admin.ListConsumerGroupOffsetsResult;
import org.apache.kafka.clients.admin.ListConsumerGroupsResult;
import org.apache.kafka.clients.admin.NewTopic;
import org.apache.kafka.clients.consumer.OffsetAndMetadata;
import org.apache.kafka.clients.producer.KafkaProducer;
Expand Down Expand Up @@ -262,21 +267,30 @@ private static boolean generateData() throws Exception {
"service-call-view-events", 27L,
"span-event-view", 50L,
"log-event-view", 0L);
int retry = 0;
while (!areMessagesConsumed(endOffSetMap) && retry++ < 5) {
Thread.sleep(2000);
int retry = 0, maxRetries = 50;
while (!areMessagesConsumed(endOffSetMap) && retry++ < maxRetries) {
Thread.sleep(6000); // max 5 min wait time
}
// stop this service
viewGen.stop();

return retry < 5;
return retry < maxRetries;
}

private static boolean areMessagesConsumed(Map<String, Long> endOffSetMap) throws Exception {
ListConsumerGroupOffsetsResult consumerGroupOffsetsResult =
adminClient.listConsumerGroupOffsets("");
Map<TopicPartition, OffsetAndMetadata> offsetAndMetadataMap =
consumerGroupOffsetsResult.partitionsToOffsetAndMetadata().get();
ListConsumerGroupsResult listConsumerGroups = adminClient.listConsumerGroups();
List<String> groupIds = listConsumerGroups.all().get().stream()
.filter(consumerGroupListing -> consumerGroupListing.isSimpleConsumerGroup())
.map(consumerGroupListing -> consumerGroupListing.groupId())
.collect(Collectors.toUnmodifiableList());

Map<TopicPartition, OffsetAndMetadata> offsetAndMetadataMap = new HashMap<>();
for(String groupId : groupIds) {
ListConsumerGroupOffsetsResult listConsumerGroupOffsetsResult = adminClient.listConsumerGroupOffsets(groupId);
Map<TopicPartition, OffsetAndMetadata> metadataMap = listConsumerGroupOffsetsResult.partitionsToOffsetAndMetadata().get();
metadataMap.forEach((k, v) -> offsetAndMetadataMap.putIfAbsent(k, v));
}

if (offsetAndMetadataMap.size() < 6) {
return false;
}
Expand Down