fix: the integration test with latest pinot image for group.id change#146
Merged
aaron-steinfeld merged 4 commits intooptimize-functionsfrom Jun 28, 2022
Merged
Conversation
kotharironak
commented
Jun 28, 2022
|
|
||
| pinotServiceManager = | ||
| new GenericContainer<>(DockerImageName.parse("hypertrace/pinot-servicemanager:main")) | ||
| new GenericContainer<>(DockerImageName.parse("traceableai-docker.jfrog.io/hypertrace/pinot-servicemanager:test")) |
Contributor
Author
There was a problem hiding this comment.
Once https://github.com/hypertrace/pinot/pull/106/files is merged, can be reverted.
Codecov Report
@@ Coverage Diff @@
## optimize-functions #146 +/- ##
========================================================
+ Coverage 79.73% 82.05% +2.32%
- Complexity 618 633 +15
========================================================
Files 63 66 +3
Lines 2324 2385 +61
Branches 243 244 +1
========================================================
+ Hits 1853 1957 +104
+ Misses 372 329 -43
Partials 99 99
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kotharironak
commented
Jun 28, 2022
| Thread.sleep(2000); | ||
| int retry = 0, maxRetries = 20; | ||
| while (!areMessagesConsumed(endOffSetMap) && retry++ < maxRetries) { | ||
| Thread.sleep(6000); // max 2 min wait time |
Contributor
Author
There was a problem hiding this comment.
Somehow with the latest pinot version of servicemanager, it takes quite a time to get offset metadata for all views. It fetches offset metadata for span-event-view and backend-entity-view much fast. But for rest of the views, it takes quite some time. Had to increase it to 5 mins (first tried with 2 mins, and then 5 mins).
Unit Test Results 36 files 36 suites 8s ⏱️ Results for commit 55856df. |
aaron-steinfeld
previously approved these changes
Jun 28, 2022
aaron-steinfeld
added a commit
that referenced
this pull request
Jun 28, 2022
* feat: support configuring distinct count agg function * fix: restore missing sum * fix: the integration test with latest pinot image for group.id change (#146) * fix: the integration test with latest pinot image for group.id change * making it 5 mins for worst case * updated comments * reverted the test image * refactor: update a test config, remove unused const Co-authored-by: kotharironak <53209990+kotharironak@users.noreply.github.com>
Harnoor-se7en
pushed a commit
to razorpay/hypertrace-query-service
that referenced
this pull request
Jul 14, 2022
* feat: support configuring distinct count agg function * fix: restore missing sum * fix: the integration test with latest pinot image for group.id change (hypertrace#146) * fix: the integration test with latest pinot image for group.id change * making it 5 mins for worst case * updated comments * reverted the test image * refactor: update a test config, remove unused const Co-authored-by: kotharironak <53209990+kotharironak@users.noreply.github.com>
Harnoor-se7en
added a commit
to razorpay/hypertrace-query-service
that referenced
this pull request
Dec 8, 2022
* feat: support configuring distinct count agg function (hypertrace#143) * feat: support configuring distinct count agg function * fix: restore missing sum * fix: the integration test with latest pinot image for group.id change (hypertrace#146) * fix: the integration test with latest pinot image for group.id change * making it 5 mins for worst case * updated comments * reverted the test image * refactor: update a test config, remove unused const Co-authored-by: kotharironak <53209990+kotharironak@users.noreply.github.com> * adding config from service since kube manifest plans fail * fix: flip around division (hypertrace#147) * kube manifests isnt working so adding service config * removed config changes at app level * add dependency * add dependency * dependency udpate * dependency update * build from apm * maven aurl * maven test * dependency update * file impl * file impl * updates workflows Co-authored-by: Aaron Steinfeld <45047841+aaron-steinfeld@users.noreply.github.com> Co-authored-by: kotharironak <53209990+kotharironak@users.noreply.github.com> Co-authored-by: 13shivam <shivam.rai@razorpay.com>
Harnoor-se7en
added a commit
to razorpay/hypertrace-query-service
that referenced
this pull request
Dec 12, 2022
* feat: support configuring distinct count agg function (hypertrace#143) * feat: support configuring distinct count agg function * fix: restore missing sum * fix: the integration test with latest pinot image for group.id change (hypertrace#146) * fix: the integration test with latest pinot image for group.id change * making it 5 mins for worst case * updated comments * reverted the test image * refactor: update a test config, remove unused const Co-authored-by: kotharironak <53209990+kotharironak@users.noreply.github.com> * adding config from service since kube manifest plans fail * fix: flip around division (hypertrace#147) * kube manifests isnt working so adding service config * removed config changes at app level Co-authored-by: Aaron Steinfeld <45047841+aaron-steinfeld@users.noreply.github.com> Co-authored-by: kotharironak <53209990+kotharironak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deps on : https://github.com/hypertrace/pinot/pull/106/files