Merged
Conversation
laxmanchekka
approved these changes
Jun 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
=========================================
Coverage 82.13% 82.13%
Complexity 633 633
=========================================
Files 66 66
Lines 2385 2385
Branches 244 244
=========================================
Hits 1959 1959
Misses 329 329
Partials 97 97
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kotharironak
approved these changes
Jun 28, 2022
This comment has been minimized.
This comment has been minimized.
Harnoor-se7en
pushed a commit
to razorpay/hypertrace-query-service
that referenced
this pull request
Jul 14, 2022
13shivam
pushed a commit
to razorpay/hypertrace-query-service
that referenced
this pull request
Dec 8, 2022
Harnoor-se7en
added a commit
to razorpay/hypertrace-query-service
that referenced
this pull request
Dec 8, 2022
* feat: support configuring distinct count agg function (hypertrace#143) * feat: support configuring distinct count agg function * fix: restore missing sum * fix: the integration test with latest pinot image for group.id change (hypertrace#146) * fix: the integration test with latest pinot image for group.id change * making it 5 mins for worst case * updated comments * reverted the test image * refactor: update a test config, remove unused const Co-authored-by: kotharironak <53209990+kotharironak@users.noreply.github.com> * adding config from service since kube manifest plans fail * fix: flip around division (hypertrace#147) * kube manifests isnt working so adding service config * removed config changes at app level * add dependency * add dependency * dependency udpate * dependency update * build from apm * maven aurl * maven test * dependency update * file impl * file impl * updates workflows Co-authored-by: Aaron Steinfeld <45047841+aaron-steinfeld@users.noreply.github.com> Co-authored-by: kotharironak <53209990+kotharironak@users.noreply.github.com> Co-authored-by: 13shivam <shivam.rai@razorpay.com>
Harnoor-se7en
added a commit
to razorpay/hypertrace-query-service
that referenced
this pull request
Dec 12, 2022
* feat: support configuring distinct count agg function (hypertrace#143) * feat: support configuring distinct count agg function * fix: restore missing sum * fix: the integration test with latest pinot image for group.id change (hypertrace#146) * fix: the integration test with latest pinot image for group.id change * making it 5 mins for worst case * updated comments * reverted the test image * refactor: update a test config, remove unused const Co-authored-by: kotharironak <53209990+kotharironak@users.noreply.github.com> * adding config from service since kube manifest plans fail * fix: flip around division (hypertrace#147) * kube manifests isnt working so adding service config * removed config changes at app level Co-authored-by: Aaron Steinfeld <45047841+aaron-steinfeld@users.noreply.github.com> Co-authored-by: kotharironak <53209990+kotharironak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Flip division from inside sum aggregation to outside, allowing pinot to optimize with star tree.
Testing
Unit tests, verified optimization with pinot explain plain
Checklist: